Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maker: Add parameter -fix_nucleotides #3750

Merged
merged 3 commits into from Jun 22, 2021
Merged

Update Maker: Add parameter -fix_nucleotides #3750

merged 3 commits into from Jun 22, 2021

Conversation

@gallardoalba
Copy link
Contributor

@gallardoalba gallardoalba commented Jun 21, 2021

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

This PR includes the -fix_nucleotides parameter. This is required when input sequences contain non-IUPAC characters. It solves the error reported in https://help.galaxyproject.org/t/how-to-do-augustus-training-or-maker-training/6221/5?u=gallardoalba

@@ -1,5 +1,5 @@
<?xml version="1.0"?>
<tool id="maker" name="Maker" profile="16.04" version="@VERSION@">
<tool id="maker" name="Maker" profile="16.04" version="@VERSION@+galaxy1">
Copy link
Member

@bgruening bgruening Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading

Copy link
Contributor Author

@gallardoalba gallardoalba Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, do you think this parameter should be enabled by default?

Loading

Copy link
Member

@bgruening bgruening Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have this by default, our bot can bump the version number automatically.

Loading

@bgruening bgruening merged commit 38b61f1 into galaxyproject:master Jun 22, 2021
9 checks passed
Loading
@gallardoalba gallardoalba deleted the add_parameter_maker branch Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants