Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Beagle tool #3760

Merged
merged 7 commits into from Jul 3, 2021
Merged

Add Beagle tool #3760

merged 7 commits into from Jul 3, 2021

Conversation

@gallardoalba
Copy link
Contributor

@gallardoalba gallardoalba commented Jun 26, 2021

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

This tool was requested by a user in GHelp: original post.

tools/beagle/beagle.xml Outdated Show resolved Hide resolved
Loading
help="It specifies a VCF file containing genotypes for the study samples.
Each VCF record must contain a GT (genotype) format field"/>
<section name="optional_inputs" title="Optional input files" expanded="true">
<param argument="ref" type="data" format="vcf,binary" optional="true" label="Bref3 or VCF file with phased genotypes"
Copy link
Member

@bgruening bgruening Jun 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

binary is bad, what is that? Do we need to add a new filetype?

Loading

Copy link
Member

@bgruening bgruening Jun 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also just support VCF.

Loading

Copy link
Contributor Author

@gallardoalba gallardoalba Jun 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try to include a new filetype; the binary format is bref3 https://faculty.washington.edu/browning/beagle/bref3.14May18.pdf.

Loading

Copy link
Contributor Author

@gallardoalba gallardoalba Jun 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading

tools/beagle/beagle.xml Outdated Show resolved Hide resolved
Loading
#end if
beagle
gt='${gt}'
#if $optional_inputs.ref and $optional_inputs.ref.ext == 'binary'
Copy link
Member

@bgruening bgruening Jun 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do need to get rid of the binary here ... add a new filetype?

Loading

@bgruening bgruening merged commit ccb3f8e into galaxyproject:master Jul 3, 2021
8 checks passed
Loading
@gallardoalba gallardoalba deleted the add_beagle_tool branch Jul 3, 2021
davebx added a commit to davebx/tools-iuc that referenced this issue Jul 8, 2021
* add_beagle

* Fix boolean options

* Fix tests

* Fix test 1

* Include bref3 format and log output option

* Include bref3 datatype

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants