Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeepVariant tool #3919

Merged
merged 12 commits into from Sep 6, 2021
Merged

Add DeepVariant tool #3919

merged 12 commits into from Sep 6, 2021

Conversation

@gallardoalba
Copy link
Contributor

@gallardoalba gallardoalba commented Sep 3, 2021

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)
tools/deepvariant/deepvariant.xml Show resolved Hide resolved
Loading
@bgruening bgruening merged commit e46feb5 into galaxyproject:master Sep 6, 2021
8 checks passed
Loading
@bgruening
Copy link
Member

@bgruening bgruening commented Sep 6, 2021

Awesome, thanks @gallardoalba!

Loading

@mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Sep 27, 2021

@bgruening I think we should have had a discussion first on whether we will merge container-only tools and under which conditions we will do that, and whether there need to be improvements in Galaxy and the TS interface on how admins are alerted to this fact. There is https://anaconda.org/bioconda/deepvariant, was there a reason this couldn't be used ?

Loading

@gallardoalba
Copy link
Contributor Author

@gallardoalba gallardoalba commented Sep 27, 2021

@bgruening I think we should have had a discussion first on whether we will merge container-only tools and under which conditions we will do that, and whether there need to be improvements in Galaxy and the TS interface on how admins are alerted to this fact. There is https://anaconda.org/bioconda/deepvariant, was there a reason this couldn't be used ?

I just used it because it is the developer's recommendation https://github.com/google/deepvariant#how-to-run-deepvariant

Loading

@bgruening
Copy link
Member

@bgruening bgruening commented Sep 27, 2021

There is https://anaconda.org/bioconda/deepvariant, was there a reason this couldn't be used?

This package has multiple problems and no tests: https://github.com/bioconda/bioconda-recipes/blob/master/recipes/deepvariant/meta.yaml
The real show-stopper is that it does not compile under older glibc and thus does not fulfill the usual requirements.

Loading

@gallardoalba gallardoalba deleted the deepvariant branch Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants