Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mothur #436

Merged
merged 5 commits into from Nov 30, 2015
Merged

Mothur #436

merged 5 commits into from Nov 30, 2015

Conversation

shiltemann
Copy link
Member

Changed merge-files tool to use multiple=true instead of a repeat for the input files, and started a macro file (only has the requirement in it for now), and added some tests with handmade artificial data (maybe can replace later if somebody has good testing datasets)

and to make planemo happy I also: added citation (please double check), changed indentation, moved requirements to the top, changed format="input" to format_source

<conditional name="merge">
<param name="type" type="select" format="fasta,qual,groups,names,accnos" label="Merge">
<option value="fasta">fasta</option>
<option value="qual">qual</option>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shiltemann I guess we can replace this entirely by:

<param name="inputs" type="data" format="fasta,qual,groups,names,accnos" multiple="true" label="inputs - fasta"/>

Do we need the select box for datatype?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would be fine by me, I just don't know how much users want/need/like the filtering on their inputs to ensure they select all files of the same and intended datatype.. maybe some of the others can weigh in on this too..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all files must be of the same type, then I'm in favour of @shiltemann's approach here. If mixed are a allowed I lean towards @bgruening's.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this only makes sense if the files are all of the same type.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand it (but I'm no mothur expert), you would only ever do a merge on files of the same data type. If we can add a validator to the param to check all files are same format that would probably work too, but I don't know if that's possible?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably easier to write than a validator and clearer to the users about the expectations.

@bgruening
Copy link
Member

Otherwise, this looks great!

blankenberg added a commit that referenced this pull request Nov 30, 2015
@blankenberg blankenberg merged commit 6242fe4 into galaxyproject:mothur Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants