New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Makefile for more flexible hosting params and incremental builds #968

Merged
merged 4 commits into from Nov 15, 2018

Conversation

Projects
None yet
3 participants
@mtekman
Contributor

mtekman commented Aug 21, 2018

No description provided.

Makefile Outdated
@@ -46,11 +49,11 @@ install: clean ## install dependencies
.PHONY: install
serve: ## run a local server}
${JEKYLL} serve -d _site/training-material
${JEKYLL} serve -d _site/training-material -P ${PORT} -H ${HOST} `[ "${INCREMENTAL}" != "" ] && echo '--incremental'`

This comment has been minimized.

@bebatut

bebatut Aug 21, 2018

Member

Why not using just ${INCREMENTAL} there and define INCREMENTAL?= or INCREMENTAL?=--incremental?
I am definitely not an expert for that

This comment has been minimized.

@mtekman

mtekman Aug 24, 2018

Contributor

I thought of that initially, but then the command line would look a bit weird:

make serve HOST=something PORT=1234 INCREMENTAL=--incremental

I thought instead that something like:

make serve HOST=something PORT=1234 INCREMENTAL=yes

would look better on the cli, but with the flexibility that the yes value could be anything

make serve HOST=something PORT=1234 INCREMENTAL=true
make serve HOST=something PORT=1234 INCREMENTAL=T

This comment has been minimized.

@bebatut

bebatut Aug 24, 2018

Member

even make serve HOST=something PORT=1234 INCREMENTAL=false currently 😄

This comment has been minimized.

@mtekman

mtekman Aug 24, 2018

Contributor

true --- okay, I've left it up to the user to set the INCREMENTAL var, although this could be used as a hook to pass any kind of flag to jekyll. Not sure if this is the best way, but I do not know Make well enough to be able to override shell ENV variables

make serve HOST=something PORT=1234 INCREMENTAL=--incremental

mtekman and others added some commits Aug 24, 2018

@erasche

This comment has been minimized.

Member

erasche commented Nov 15, 2018

Thanks @mtekman!

(Makefile is not under testing, so not waiting for it to pass.)

@erasche erasche merged commit b2e4800 into galaxyproject:master Nov 15, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@mtekman mtekman deleted the mtekman:makefile branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment