Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logger module for logging #65

Closed
mzal opened this issue Sep 14, 2020 · 0 comments
Closed

Use logger module for logging #65

mzal opened this issue Sep 14, 2020 · 0 comments
Assignees
@mzal
Labels
enhancement New feature or request

Comments

@mzal
Copy link
Collaborator

mzal commented Sep 14, 2020

Remove any stray printfs, add #define to enable/disable non-critical logging
@mzal mzal self-assigned this Sep 14, 2020
@mzal mzal added the enhancement New feature or request label Sep 14, 2020
@mzal mzal removed their assignment Sep 15, 2020
mzal pushed a commit that referenced this issue Sep 27, 2020
route all logging through logging module API (closes #65)
d344ecd 
* move instruction printing in debug builds to debug_print_instruction,
  which internally uses logger_print
* only declare LOG_ASSERT in debug builds
* change logger API:
	* change logger_log to use variadic arguments
	* add logger_print as a lightweight alternative to logger_log
	* remove logger_get_msg_buffer as it is no longer used
* use new logger API in other modules, remove all console output outside logger module
@mzal mzal self-assigned this Sep 27, 2020
mzal pushed a commit that referenced this issue Sep 27, 2020
route all logging through logging module API (closes #65)
6accb6f 
* move instruction printing in debug builds to debug_print_instruction,
  which internally uses logger_print
* only declare LOG_ASSERT in debug builds
* change logger API:
	* change logger_log to use variadic arguments
	* add logger_print as a lightweight alternative to logger_log
	* remove logger_get_msg_buffer as it is no longer used
* use new logger API in other modules, remove all console output outside logger module
* centralize fatal error logging in mem
mzal pushed a commit that referenced this issue Sep 27, 2020
route all logging through logging module API (closes #65)
fdfb0f9 
* move instruction printing in debug builds to debug_print_instruction,
  which internally uses logger_print
* only declare LOG_ASSERT in debug builds
* change logger API:
	* change logger_log to use variadic arguments
	* add logger_print as a lightweight alternative to logger_log
	* add logger_prepare and logger_destroy to handle bufferred output
	* remove logger_get_msg_buffer as it is no longer used
* use new logger API in other modules, remove all console output outside logger module
* centralize fatal error logging in mem
@mzal mzal closed this as completed in c0f3f26 Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mzal mzal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mzal