Fixed directions unitSystem option rendering #17

Closed
wants to merge 1 commit into
from

2 participants

@e1himself

When the $this->directions->request_options['units'] option is defined getMapJS method rendered this javascript code:

{
unitSystem: google.maps.DirectionsUnitSystem.1
}

Obviously this is wrong.

Also 'imperial' and 'metric' string literals should be uppercase. Because google.maps.DirectionsUnitSystem contains IMPERIAL and METRIC constants but not imperial and metric.

@e1himself e1himself Fixed directions unitSystem option rendering
When the `$this->directions->request_options['units']` option is defined this code rendered 
```javascript
unitSystem: google.maps.DirectionsUnitSystem.1
```
javascription code. This is wrong.

Also 'imperial' and 'metric' string literals should be uppercase. Because `google.maps.DirectionsUnitSystem` contains `IMPERIAL` and `METRIC` constants but not `imperial` and `metric`.
1902f36
@e1himself

Is there something wrong with this bugfix?

@galen galen added a commit that closed this pull request Mar 5, 2013
@galen Merge patch from @e1himself. Closes #17. 04d13fd
@galen galen closed this in 04d13fd Mar 5, 2013
@galen
Owner

Nothing was wrong I was just busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment