Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom screenshot handler for layout check #191

Closed
ishubin opened this issue Jan 7, 2015 · 2 comments
Closed

Custom screenshot handler for layout check #191

ishubin opened this issue Jan 7, 2015 · 2 comments

Comments

@ishubin
Copy link
Member

ishubin commented Jan 7, 2015

Galen should be more extendable once it comes to taking screenshot. Users should be able to override the Galen behavior on making screenshot when the it checks layout.

Users should be able to

  • Override functionality for taking screenshots in:
    • Java tests
    • JavaScript tests
    • Standard Test Suite
  • Generate layout report without screenshot at all.
@ishubin
Copy link
Member Author

ishubin commented Jan 31, 2015

I think I know how to implement it without serious refactoring. Just create a function which accepts a screenshot as an argument. This way in checkLayout method it will not make screenshot any more.

// in javascript

checkLayout({
    driver: driver,
    path: "homepage.spec",
    screenshot: "screenshot.jpg"
});

@anuragipankaj
Copy link

hi, i am trying to take screenshot , but its still giving me screenshot with header and footer , here is my code for the same:

image = await browser.takeScreenshot();
i'm using webdriverio+appium (1.15.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants