New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker updates #298

Merged
merged 10 commits into from Nov 2, 2018

Conversation

Projects
None yet
1 participant
@marklescroart
Contributor

marklescroart commented Nov 1, 2018

In constructing the viewer for my paper, I made a few updates to the javascript & other code. The biggest two changes are (1) to allow selection of a different dataset to activate a second javascript picker function (Alex did this in his viewer for his Nature paper before the dataset selection code existed in the webgl version of pycortex, so this was necessary), (2) to allow input of external SVG files for customized display layers in a webgl static viewer, and (3) to allow selection of which layers of an overlays svg file are ultimately available in the viewer. For example, one might want to get rid of the cutouts layer, which is used in quickflat but not so useful to include in a webgl display, or to select among a few options for fancy display layers in an external file.

There are a few changes that don't do anything yet, e.g. the allowtilt variable in mriview_surface.js (which is meant to allow / disallow tilting of the flatmap, addressing #286 ) doesn't do anything yet. A harmless addition, tho. Also, I silenced several of the three.js deprecation warnings that totally clog the javascript console and make it difficult to debug javascript issues. A more permanent (ha) solution would be to update the versions of three.js (and potentially other code) that we distribute with pycortex, but James says that is the road to perdition and laughably stupid, because these types of javascript libraries change all the time and are never backward compatible, so I have refrained.

@marklescroart

This comment has been minimized.

Contributor

marklescroart commented Nov 1, 2018

Ya also re: three.js see #46

@marklescroart marklescroart merged commit 4f0be7e into master Nov 2, 2018

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment