Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable passing an ax in quick flatmap: quickshow(fig=ax) #325

Merged
merged 2 commits into from Apr 5, 2019

Conversation

Projects
None yet
2 participants
@TomDLT
Copy link
Contributor

TomDLT commented Apr 4, 2019

This PR enables plotting a flatmap in a matplotlib Axes, so you can plot multiple flatmaps in the same Figure.

The changes are in 5b9c548.
The other commit 18971a4 is only removing unused imports and doing some pep8 alignments.

Example:
save

@marklescroart

This comment has been minimized.

Copy link
Contributor

marklescroart commented on 5b9c548 Apr 4, 2019

Looks good. Out of curiosity - does this work OK with resizing figures outside of notebooks? I'm not sure if that's necessary (can't remember the last time I used stand-alone figures plotted from a terminal ipython session), but it would be good to at least know if this breaks that functionality.

This comment has been minimized.

Copy link
Contributor Author

TomDLT replied Apr 4, 2019

Yes, it does work well with resizing and zooming in stand-alone figures.

@TomDLT TomDLT merged commit 6224efd into gallantlab:master Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.