Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fsaverage transform #334
Thanks for this. Please don't merge yet as I see some weird commits listed there. I can review tomorrow…
On Tue, Jul 16, 2019, 11:59 PM MShinkle ***@***.***> wrote: Incorporating transformation matrices to fsaverage transform ------------------------------ You can view, comment on, or merge this pull request online at: #334 Commit Summary - ENH add mri_surf2surf matrix - FIX remove fstrings and whitespace - string formatting - FIX: format string - ENH: allow setting custom subjects_dir in mri_surf2surf - FIX: print function for py2 - update to freesurfer alignment to allow reference image input from intial alignment - Merge branch 'fsaverage_transform' of github.com:gallantlab/pycortex into fsaverage_transform - Update to cut_surface to check whether fiducial vertex count matches inflated vertex count; avoids wasted work segmenting surfaces that won't flatten File Changes - *M* cortex/align.py <https://github.com/gallantlab/pycortex/pull/334/files#diff-0> (75) - *M* cortex/freesurfer.py <https://github.com/gallantlab/pycortex/pull/334/files#diff-1> (199) - *M* cortex/segment.py <https://github.com/gallantlab/pycortex/pull/334/files#diff-2> (9) - *M* cortex/xfm.py <https://github.com/gallantlab/pycortex/pull/334/files#diff-3> (2) Patch Links: - https://github.com/gallantlab/pycortex/pull/334.patch - https://github.com/gallantlab/pycortex/pull/334.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#334?email_source=notifications&email_token=AAJ7AC5IE67OFYX67HXH4G3P7ZAE3A5CNFSM4IEIM5I2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7STGHA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJ7AC57R7Y3TNDLEJ4SWQ3P7ZAE3ANCNFSM4IEIM5IQ> .
This is almost ready to go. Pls to test. Relevant new function is
I think it would be good to additionally have a transparent function, perhaps a method of the vertex class (and maybe of the volume class too...?) that makes use of this function and the matrices it generates to do mapping to other subjects. For example,
Not married to the idea of making this a method of vertex, nor to the name, but I like that syntax. Thoughts? Suggestions? Vetoes?