Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Add docs reflecting that we may skip some items that have invalid par…

  • Loading branch information...
1 parent aa40bdd commit 8559cdb5b6bfa87864941f726521660023779fa7 @bharat bharat committed
Showing with 4 additions and 0 deletions.
  1. +4 −0 modules/gallery/helpers/gallery_task.php
4 modules/gallery/helpers/gallery_task.php
@@ -357,6 +357,10 @@ static function fix($task) {
// We'll do a depth-first tree walk over our hierarchy using only the adjacency data because
// we don't trust MPTT here (that might be what we're here to fix!). Avoid avoid using ORM
// calls as much as possible since they're expensive.
+ //
+ // NOTE: the MPTT check will only traverse items that have valid parents. It's possible that
+ // we have some tree corruption where there are items with parent ids to non-existent items.
+ // We should probably do something about that.
while ($state != self::FIX_STATE_DONE && microtime(true) - $start < 1.5) {
switch ($state) {

0 comments on commit 8559cdb

Please sign in to comment.
Something went wrong with that request. Please try again.