Refactored item_Model::get_position() as an item helper and fixed viewable() related issues#23
Closed
jersub wants to merge 2 commits into
Closed
Refactored item_Model::get_position() as an item helper and fixed viewable() related issues#23jersub wants to merge 2 commits into
jersub wants to merge 2 commits into
Conversation
added 2 commits
January 9, 2011 12:14
…lls the viewable() method on every query.
…y, when some other items belonging to the same parent album are not viewable. Changed depracated calls to item_Model::get_position() to item::get_position().
Member
|
This looks awesome. Great work.. pulling it now. |
Contributor
Author
|
Thanks a lot bharat! ;) |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a pull alternative to the previous one: Fix item_Model::get_position() and item controllers.
As bharat suggested, this is far cleaner to refactor
item_Model::get_position()as an item helper. However, a backward compatibility has been kept.Now it's possible to use a third-party module, as "hide", that can alter gallery's original permission policy.
Past related issues have been reported in the "hide" thread : http://gallery.menalto.com/node/97962
Request for comments/pull!
Regards,
Jeremy