Normal should not be displayed for polygons in OpenGL #2087

Closed
ptaillandier opened this Issue Jan 4, 2017 · 5 comments

Projects

None yet

4 participants

@ptaillandier
Contributor

Steps to reproduce

  1. Test this simple model:
    model drawPolygon
    experiment drawPolygon type: gui {
    output {
    display view type: opengl {
    graphics "square" {draw square(20) color: #yellow;}
    }
    }
    }

Expected behavior

Only the yellow square should be displayed

Actual behavior

In addition, the normal vector (red arrow) is displayed.

@nordie69
nordie69 commented Jan 10, 2017 edited

I can confirm, that this behaviour is the same here at my system environment (Windows 8.1). My model changed it's behaviour a few GIT builds ago like Patrick described it.

In my opinion it is not only happening for polygons, the normal vector is also displayed for lines.

Thanks,
Stefan

@agrignard
Contributor
@agrignard
Contributor
@agrignard agrignard added a commit that closed this issue Jan 10, 2017
@agrignard agrignard fixes #2087
I just put isDrawingNormals to false by default and add a condition in
drawTesselatedPolygon.
4e9419c
@agrignard agrignard closed this in 4e9419c Jan 10, 2017
@AlexisDrogoul
Member

Yes I confirm it was my fault -- and I should have made the simple fix before, but I'm still struggling with the refactoring of the code. Normals are essential to obtain a correct rendering and I needed to display them. Sorry for that. The fix made by Arnaud is ok, but will be reverted some time in the future.

@nordie69

I am happy to see, that now everything works fine again with the latest GIT version and my model (see attached screenshot). Thanks and keep up the good work. Maybe one day I will be able to helpwith issues like that ....

Stefan

clipboard01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment