Skip to content

Miscellaneous improvements of the models packaged with gama #251

Merged
lesquoyb merged 13 commits into
2024-06from
improve-library-models
Jul 17, 2024
Merged

Miscellaneous improvements of the models packaged with gama #251
lesquoyb merged 13 commits into
2024-06from
improve-library-models

Conversation

@lesquoyb

Copy link
Copy Markdown
Contributor

No description provided.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Code Health of removed files: 0.00

View detailed results in CodeScene

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Code Health of removed files: 0.00

View detailed results in CodeScene

- Adds minimum_cycle_duration to smooth models with agent movements
- better cameras
- force 2d when it makes sense
- force autorun when it makes sense
- improve legends and overlays in some displays

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Code Health of removed files: 0.00

View detailed results in CodeScene

- forces autorun when it makes sense
- force 2d instead of 3d when possible to gain screen space (and performances)

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Code Health of removed files: 0.00

View detailed results in CodeScene

- renaming some models to get uniform names
- improved comments/write statements
- adds some minimum_cycle_duration
- removes useless variables
- fixes some logical errors
- forces 2d on some displays
- better camera for some models
- asks the user to give it's access token in the mapbox model

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Code Health of removed files: 0.00

View detailed results in CodeScene

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Code Health of removed files: 0.00

View detailed results in CodeScene

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Code Health of removed files: 0.00

View detailed results in CodeScene

@lesquoyb lesquoyb merged commit 079c971 into 2024-06 Jul 17, 2024
@lesquoyb lesquoyb deleted the improve-library-models branch July 17, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant