Proposal to remove the trim bar to gain vertical space - #319
Merged
Merged
Conversation
Replacement of the default HeapStatus control of Eclipse by a simple icon in the top-right corner.
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| public Control createWidget(final Composite parent) { | ||
| composite = new Composite(parent, SWT.NONE); | ||
| GridLayoutFactory.fillDefaults().margins(0, 0).spacing(0, 0).extendedMargins(0, 5, 5, 5).numColumns(2) | ||
| GridLayoutFactory.fillDefaults().margins(0, 0).spacing(0, 0).extendedMargins(0, 5, 5, 5).numColumns(3) |
There was a problem hiding this comment.
❌ Getting worse: Complex Method
createWidget already has high cyclomatic complexity, and now it increases in Lines of Code from 115 to 117
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removal of the trim being present by default in Edition / Simulation perspectives (possibility to reinstate it using the layout statement).
Replacement of the default HeapStatus control of Eclipse by a simple icon in the top-right corner, with a tooltip to indicate the memory, and removal of the timer task used to compute the memory in background.