[WIP] Bump to eclipse 2025 03#414
Merged
Merged
Conversation
Seems to be a drop-in replacement, most noticeable diff is the explicit `.trim()` as discussed there : https://github.com/eclipse-equinox/p2/pull/604/files
Please make sure it doesn't break anything, it's compilation safe
This change eliminates one layer of threading (the view update thread), which does not appear to be necessary as both OpenGL and Java2D views use another thread to paint or animate their contents (they are not SWT components)
Also bumps the required version to 23
Otherwise I would get obscure compilation errors ... strange. Maybe is it a consequence of me using the RC1 ?
Member
|
I think we need, as soon as 2025-03 is official (see https://eclipseide.org) to:
I'm already working in 2025-03 / JDK 23 w/o issues (other than the occasional error introduced by JDT compilation default rules changing). |
Member
|
🛑 STOP 🛑 I have uncovered an issue with the XText version shipped with 2025-03 RC1. See eclipse-xtext/xtext@2f2fe5d#commitcomment-153272813 In addition to this comment, I will also post an issue, to make sure it can be fixed before they roll out the projects... But so far, most of the editor is not really usable with this version of XText. |
Member
|
I've managed, with the help of the XText developers, to workaround this issue. So far so good ! |
Remove the storage of canvas
AlexisDrogoul
approved these changes
Mar 15, 2025
Member
AlexisDrogoul
left a comment
AlexisDrogoul
left a comment
There was a problem hiding this comment.
Compilation and execution work very well on macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing fancy update upgrading from Eclipse 2024-06 to early 2025-03. I also fixed some compilation errors (see commit for each issue) and some stuff for GHA and latest Tycho features.
Please try it and report if any issue.
The build is still made on JDK 21, but might upgrade it too to non-LTS 23 to fix a MacOS issue