New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exporting .sav files #46

Open
jbmorley opened this Issue Mar 6, 2016 · 38 comments

Comments

Projects
None yet
@jbmorley
Collaborator

jbmorley commented Mar 6, 2016

No description provided.

@jbmorley jbmorley added the enhancement label Mar 6, 2016

@jbmorley

This comment has been minimized.

Collaborator

jbmorley commented Mar 24, 2016

@taisel Do you know if any of the existing GameBoy-Online save methods support saving in a .sav format compatible with other emulators? There look to be quite a few different formats supported but I'm not too sure what I should be looking for... Thanks!

@taisel

This comment has been minimized.

Contributor

taisel commented Mar 25, 2016

See the exporting as "RAW" save code in:
https://github.com/taisel/GameBoy-Online/blob/master/js/other/gui.js#L490

.sav files are usually a binary dump of the SRAM, except RTC (only thing incompatible/wouldn't be cross-emulator).

@taisel

This comment has been minimized.

Contributor

taisel commented Mar 25, 2016

The same save system was also replicated into IodineGBA, although relicensed at MIT, which I need to do for gameboy-online.

@taisel

This comment has been minimized.

Contributor

taisel commented Mar 25, 2016

Since you're contributing with these pull requests, you probably should pull request a copyright update maybe. I changed it to MIT license just now before these pull requests become of considerable size, so the re-licensing of my portion is done before more is pulled in.

@taisel

This comment has been minimized.

Contributor

taisel commented Mar 25, 2016

I really don't care what people do with my contributions, and I don't want to deal with the emails that ask whether it's ok to modify + host at x/y/z due to GPL.

@taisel

This comment has been minimized.

Contributor

taisel commented Mar 25, 2016

@jbmorley

This comment has been minimized.

Collaborator

jbmorley commented Mar 25, 2016

@taisel Thanks so much for merging this.

As for the license, I plan to make a similar change to gameplay since I would typically choose to use the MIT license.

@davson19

This comment has been minimized.

davson19 commented Aug 3, 2016

Any updates on this?

@gradapin

This comment has been minimized.

gradapin commented Aug 4, 2016

It would be really cool !
I tried to figure out where savefiles are stored by looking into the code but couldn't find it.

@jbmorley

This comment has been minimized.

Collaborator

jbmorley commented Aug 4, 2016

Unfortunately .sav files aren't used internally, which is what makes this a separate piece of work. I agree it wold be really cool 👍 .

@Olenka1810

This comment has been minimized.

Olenka1810 commented Aug 20, 2016

+1 If your read the roms from google drive, maybe sav files (when available) can be dumped there as well? That would be totally awesome :-)

Btw great job on the emulator. Best solution for ios I have seen so far!

@jbmorley

This comment has been minimized.

Collaborator

jbmorley commented Aug 24, 2016

@Olenka1810 That's how I'd like for it to work, yes.

@welcoMattic

This comment has been minimized.

welcoMattic commented Aug 29, 2016

I just wrote a small gist to export .sav file from Gameplay local data : https://gist.github.com/welcoMattic/2a2909e5b98aa8d745dfd0df0a6b3091

Enjoy ;)

@welcoMattic

This comment has been minimized.

welcoMattic commented Aug 29, 2016

It can be a base to build the "Export .sav file to Google Drive" feature ;)

@jbmorley

This comment has been minimized.

Collaborator

jbmorley commented Aug 29, 2016

@welcoMattic Thanks for looking into this; that's a great start. I'm looking for ways to test the validity of the save file against different emulators, so if you have any suggestions of emulators you've tested with then that'd be super-helpful.

@welcoMattic

This comment has been minimized.

welcoMattic commented Aug 29, 2016

@jbmorley You can test gamebattle, it's used by OpenEmu.
I'm trying to write a small import script, based on https://github.com/taisel/GameBoy-Online source code

@welcoMattic

This comment has been minimized.

welcoMattic commented Aug 29, 2016

Ref. #72

@Shawnjoseph2001

This comment has been minimized.

Shawnjoseph2001 commented Nov 3, 2016

It would be helpful if you could at least use Game Play Color saves as backups/ across devices with Game Play Color or Gameboy-Online with raw save data, even if it's not cross platform/emulator.

@Shawnjoseph2001

This comment has been minimized.

Shawnjoseph2001 commented Nov 3, 2016

@welcoMattic Just wondering, how would I use the this with a copy of Game Play Color/how would I patch it to Game Play Color?

@welcoMattic

This comment has been minimized.

welcoMattic commented Nov 3, 2016

@Shawnjoseph2001 I didn't include the Gist into GPC, but juste execute it in Safari web console with my iPhone connected via USB. Hugly hack to extract my save

@ughwire

This comment has been minimized.

ughwire commented Nov 21, 2016

@welcoMattic I tried executing the code in the safari web console but am getting this error:

image

Any ideas?

@duckboy2001

This comment has been minimized.

duckboy2001 commented Nov 22, 2016

Sorry, I'm not too sure what a .sav file is. Will this allow me to save my games to my Google Drive? I just upgraded my phone and Gameplay Color wasn't saved on my iTunes backup. If this worked would I be able to transfer my saved data onto my new phone? I will continue playing on my old phone anyways, but if I didn't have to haul around two phones that would be great.

@Nythepegasus

This comment has been minimized.

Nythepegasus commented Dec 6, 2016

@duckboy2001 A .sav file is a save file. It would be saved into Google Drive. It would allow to transfer your progress between devices.

@welcoMattic

This comment has been minimized.

welcoMattic commented Dec 6, 2016

@ughwire If you don't know Javascript, I recommend you to don't use a Javascript script.
First, you didn't replace the value 'ROM_NAME', so the script can't work.

@zensir

This comment has been minimized.

zensir commented Apr 18, 2017

can anyone write nstroctions on how to import export savs? thanx!

@kdr264

This comment has been minimized.

kdr264 commented Sep 25, 2017

Quick question, has there been any progress on this? Not to sound ungrateful, because I absolutely love gameplay. I would offer to help, but I chose the wrong profession and therefore I don't know any code lol I can paypal people though if thats an incentive :D

@Vinnybonboot

This comment has been minimized.

Vinnybonboot commented Oct 27, 2017

Any progress report on this? I love this app, but I'm about to get a phone upgrade, which means I will lose all of my game saves. I'd be pretty bummed if I have to lose all my progress in the games. It'd be great if I could upload the saves to Google Drive or iCloud.

@zensir

This comment has been minimized.

zensir commented May 24, 2018

any update on this? is there any way we can help develope this feature? thnx!

@joshuafinley

This comment has been minimized.

joshuafinley commented Jul 12, 2018

I would really love this feature too, this emulator is fantastic and I would like a way of transferring the save to a pc emulator to trade pokemon and battle friends. Keep up the good stuff

@MikeG1990

This comment has been minimized.

MikeG1990 commented Jul 29, 2018

Any updates yet? would love to transfer my save file to pc and complete the pokedex on Crystal using a trade emulator lol. Honestly I love the Emulator, this feature would make it a perfect Gameboy emulator. Or is no one working on it anymore? lol. I mean if found it impossible and quit then I can understand that @jbmorley

@Shawnjoseph2001

This comment has been minimized.

Shawnjoseph2001 commented Jul 29, 2018

@MikeG1990

This comment has been minimized.

MikeG1990 commented Jul 29, 2018

@Shawnjoseph2001 fair enough If it impossible nothing can be done I'll just restart on a PC emulator.

@jbmorley

This comment has been minimized.

Collaborator

jbmorley commented Jul 29, 2018

Unforutnately I'm unable to work on this at the moment meaning the fature is on-hold indefinitely. @pvinis Is now maintainer on this project, and people are welcome to submit pull requests.

@kdr264

This comment has been minimized.

kdr264 commented Jul 29, 2018

I commented on this thread over ten months ago asking for any update so either the person who made the emulator doesn't see this thread or doesn't care enough to make his work better.

@MikeG1990

This comment has been minimized.

MikeG1990 commented Jul 29, 2018

Well the emulator is great thanks for the work you managed to do, it a shame though.

@MikeG1990

This comment has been minimized.

MikeG1990 commented Jul 29, 2018

I’m new to GitHub, I might sound dumb but what’s a pull request?

@jbmorley

This comment has been minimized.

Collaborator

jbmorley commented Jul 30, 2018

@MikeG1990 I’m glad you’re enjoying the emulator.

Since the code is open source, anyone is free to take it and modify it, adding whatever functionality they wish. A ‘pull request’ is the process by which that functionality is incorporated into the project.

@MikeG1990

This comment has been minimized.

MikeG1990 commented Jul 30, 2018

Fair enough, thanks for explaining, because it stored locally inside of Safari i the issue. I honestly don't understand javascript well enough to do something like that. I only knew basics to javascript and haven't done anything with javascript in about 10 years. Maybe there's a clever individual among the users that possibly might be able to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment