Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAVEN-207 #22

Closed

Conversation

jonathanmccann
Copy link

From @mbowerman:

The projectClassLoader object could be different for each war file that is deployed, but the toolsClassLoader object should be the same for all the war files within a directory. Therefore, we cannot rewrite the getProjectClassLoader() method in such a way that only allows it to get instantiated once.

The toolsClassLoader is sufficient for the war files to be deployed properly (I tested that they got deployed in my test environment, and Minhchau agreed that using the toolsClassLoader object would be sufficient). Therefore, we should use the toolsClassLoader object.

@gamerson
Copy link
Owner

Pull request forwarded to brianchandotcom#107.

:octocat: Sent from GH.

@gamerson gamerson closed this Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants