Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3FHL sources show up with 2 different spectra #91

Closed
joleroi opened this issue Sep 13, 2017 · 2 comments
Closed

3FHL sources show up with 2 different spectra #91

joleroi opened this issue Sep 13, 2017 · 2 comments
Assignees
Milestone

Comments

@joleroi
Copy link
Collaborator

joleroi commented Sep 13, 2017

For 3FHL sources, the webpage shows two different sets of spectral parameters

See e.g. http://gamma-sky.net/#/cat/3fhl/0

Model Info

    Significance (10 GeV - 2 TeV): 5.362
    Npred: 7.63

    Spectrum type: PowerLaw
        Spectral index: 1.672 +/- 0.827
        Pivot energy: 23.7 GeV
        Flux density at pivot energy: 5.32e-13 +/- 2.10e-13 cm-2 s-1 GeV-1

    Power law index: 2.223 +/- 0.481
    Integral flux (10 GeV - 1 TeV): 2.96e-11 +/- 1.17e-11 cm-2 s-1
    Energy flux (10 GeV - 1 TeV): 1.68e-12 +/- 1.07e-12 erg cm-2 s-1
    Significance curvature: 1.02

If there is a good reason for that it should be explained somewhere, because the way it is right now might confuse people.

@cdeil cdeil self-assigned this Sep 13, 2017
@cdeil cdeil added this to the Version 0.2 milestone Sep 13, 2017
@cdeil
Copy link
Contributor

cdeil commented Sep 13, 2017

Yes, this can be improved a bit. Assigning to myself. It's a bit related to gammapy/gammapy#1127 which I had planned to finish up tomorrow anyways.

@cdeil
Copy link
Contributor

cdeil commented Sep 15, 2017

@joleroi - Turns out that in 3FHL every source has a PL and CPL measured.
I've tried to make the display clearer in 22074c2 , it now looks like this:

screen shot 2017-09-15 at 14 42 36

--- This change is not deployed yet to the public webpage, it'll come with other improvements on the next deploy.

If you want, you can compare with the printout we have in Gammapy for a PL and CPL source:

python -c 'from gammapy.catalog import source_catalogs; print(source_catalogs["3fhl"][352])'
python -c 'from gammapy.catalog import source_catalogs; print(source_catalogs["3fhl"][1442])'

I'm very short on time, so generally pull requests in Gammapy or here are preferred, but of course reminder issues are also welcome.

@joleroi - Any further suggestions to improve or close the issue?

@cdeil cdeil closed this as completed Sep 15, 2017
@cdeil cdeil reopened this Sep 15, 2017
@cdeil cdeil assigned joleroi and unassigned cdeil Sep 15, 2017
@cdeil cdeil closed this as completed Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants