Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HGPS catalog spatial models #1031

Merged
merged 3 commits into from May 18, 2017
Merged

Conversation

@adonath
Copy link
Member

@adonath adonath commented May 18, 2017

This PR implements the SourceCatalogObjectHGPS.spatial_model method and adds corresponding tests.

@adonath adonath self-assigned this May 18, 2017
@cdeil
cdeil approved these changes May 18, 2017
Copy link
Member

@cdeil cdeil left a comment

Wonderful!

Having also helpers in Gammapy to load the diffuse band (and fill http://docs.gammapy.org/en/latest/api/gammapy.background.GaussianBand2D.html) and check that it matches the internal diffuse band 2D image would be great (and an important check before the data release).

@cdeil cdeil added this to the 0.7 milestone May 18, 2017
@cdeil
Copy link
Member

@cdeil cdeil commented May 18, 2017

Sphinx fails in the docs build are an unrelated issue in Sphinx 1.6.1.
Merging this now.

@cdeil cdeil merged commit 0f8e4ff into gammapy:master May 18, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@cdeil cdeil changed the title Implement HGPS catalog spatial models Add HGPS catalog spatial models May 21, 2017
@adonath adonath deleted the adonath:hgps_catalog_spatial_models branch Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants