Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanup of FluxPoints code and tests #1035

Merged
merged 5 commits into from May 19, 2017
Merged

Some cleanup of FluxPoints code and tests #1035

merged 5 commits into from May 19, 2017

Conversation

@cdeil
Copy link
Member

@cdeil cdeil commented May 19, 2017

This pull request continues #1032 from yesterday, and is another step towards #1034.

It's mostly cleanup, but there are some API changes:

  • Remove the old gammapy/spectrum/sherpa_chi2asym.py (wasn't used within Gammapy or tested, was part of the public API and docs, but I don't think anyone except me years ago to debug HAP FitSpectrum used it)
  • More uniform names: SEDLikelihoodProfile -> FluxPointProfiles, FluxPointsFitter -> FluxPointFitter (to be consistent with FluxPointEstimator).
  • change get_test_cases so that it runs during test execution (I think, not verified), not test collection as before.
  • Change compute_flux_points_dnde to FluxPoints.to_sed_type (a public API change, only caller in Gammapy, the Fermi catalog class is adapted) and move _e_ref_lafferty, _dnde_from_flux to static helper methods on the FluxPoints class (those weren't part of the public API, that's just an internal code organisation simplification).
  • Misc cleanup of flux_points.py and test_flux_points.py.
  • Remove docs/spectrum/flux_points.rst (contained only broken examples, and I think the same content is already in docs/spectrum/index.rst and notebooks.
  • Tutorial notebook updated in gammapy/gammapy-extra@96d187d
  • Cleanup of Crab spectrum code (unrelated to spectral points, done while I was waiting for continuous integration to run).
@cdeil cdeil added the cleanup label May 19, 2017
@cdeil cdeil added this to the 0.7 milestone May 19, 2017
@cdeil cdeil self-assigned this May 19, 2017
@cdeil cdeil changed the title Fp Some cleanup of FluxPoints code and tests May 19, 2017
@cdeil cdeil force-pushed the cdeil:fp branch from ea811fa to 7d1d4ca May 19, 2017
@cdeil
Copy link
Member Author

@cdeil cdeil commented May 19, 2017

I think I resolved all the issues in the last travis-ci build. Merging this now.

@cdeil cdeil merged commit b19f63d into gammapy:master May 19, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant