New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gammapy.utils.mpl_style #1038

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
1 participant
@cdeil
Member

cdeil commented May 19, 2017

This PR removes gammapy.utils.mpl_style and bumps the matplotlib version requirement to 1.5.

EDIT: PR description has been changed, started out as something else.

@cdeil cdeil added the cleanup label May 19, 2017

@cdeil cdeil added this to the 0.7 milestone May 19, 2017

@cdeil cdeil self-assigned this May 19, 2017

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil May 19, 2017

Member

Hmm .. this is failing in the build where no matplotlib and it's imported by pytest via gammapy/conftest.py: https://travis-ci.org/gammapy/gammapy/jobs/234094452#L976

It's easy to fix, but my suggestion would be to remove gammapy/utils/mpl_style.py completely.
The new default matplotlib 2.0 style is very nice IMO, there's no need to create a Gammapy MPL style.

I think the motivations to add the Gammapy style were:

  • the MPL 1.x style was ugly (resolved by MPL 2.0)
  • we thought that it would help for pytest-mpl image comparison tests, but I'm not sure that's true. Pinning the MPL 2.0 style should be just as easy / hard as pinning a custom MPL style that derives from it.
Member

cdeil commented May 19, 2017

Hmm .. this is failing in the build where no matplotlib and it's imported by pytest via gammapy/conftest.py: https://travis-ci.org/gammapy/gammapy/jobs/234094452#L976

It's easy to fix, but my suggestion would be to remove gammapy/utils/mpl_style.py completely.
The new default matplotlib 2.0 style is very nice IMO, there's no need to create a Gammapy MPL style.

I think the motivations to add the Gammapy style were:

  • the MPL 1.x style was ugly (resolved by MPL 2.0)
  • we thought that it would help for pytest-mpl image comparison tests, but I'm not sure that's true. Pinning the MPL 2.0 style should be just as easy / hard as pinning a custom MPL style that derives from it.

@cdeil cdeil changed the title from Minor fix / update for matplotlib style to Remove gammapy.utils.mpl_style May 19, 2017

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil May 19, 2017

Member

travis-ci fails are unrelated. Merging this now.

Member

cdeil commented May 19, 2017

travis-ci fails are unrelated. Merging this now.

@cdeil cdeil merged commit 8bf65a7 into gammapy:master May 19, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment