Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Development in gammapy.maps #1054
This PR contains changes related to ongoing development in
There's obviously still a lot of work to be done but I plan to continue working on this over the next few months. Once I'm satisfied that these classes have everything we need in fermipy I would start working on copying over functionality from SkyImage and SkyCube.
referenced this pull request
Jun 2, 2017
@woodmd - I don't have time for a detailed review before going on vacation.
Here's my suggestions based on a quick look:
I see this fail (because you're passing
In addition I see some warnings about unclosed files from the tests. There my suggestion would be to use
I noticed that tests for
I would also suggest to start to put
Otherwise, opening up the
Another one is the
There's also a remaining import of fermipy from here:
@woodmd - Is it useful if I point out such things?
Ok I'll have a look. I wasn't getting this error when I ran unit tests locally so it must be something to do with python3 or version of numpy.
I don't have a strong feeling about this so I'm happy to adopt whatever convention you use elsewhere.
I fully agree. If you create a page in the appropriate place of the docs hierarchy I can start writing documentation there.
Yes I'm aware of these. Most of these arise from code that I've copied from fermipy but haven't yet written unit tests for so I wouldn't really spend time on these (I can run pyflakes just as easily). What I was mainly looking for feedback on was the overall design with respect to class hierarchy and interfaces.