New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system pytest rather than astropy #1057

Merged
merged 3 commits into from Jun 3, 2017

Conversation

Projects
None yet
2 participants
@bsipocz
Member

bsipocz commented Jun 2, 2017

As the bundled one becomes deprecated in v2.0

@bsipocz

This comment has been minimized.

Show comment
Hide comment
@bsipocz

bsipocz Jun 3, 2017

Member

@cdeil - this also includes the pytest config item to setup.py that I mentioned in #1056. In my understanding this still allows the DeprecationWarnings to show up, but you may need to look into the docs in case you prefer to have a more custom customization.

Member

bsipocz commented Jun 3, 2017

@cdeil - this also includes the pytest config item to setup.py that I mentioned in #1056. In my understanding this still allows the DeprecationWarnings to show up, but you may need to look into the docs in case you prefer to have a more custom customization.

@cdeil cdeil self-assigned this Jun 3, 2017

@cdeil cdeil added this to the 0.7 milestone Jun 3, 2017

@cdeil

cdeil approved these changes Jun 3, 2017

@bsipocz - Thanks!

I have one question: at the end of running the tests I see this warning (I think it was there since many months, not introduced by this PR):

  [pytest] section in setup.cfg files is deprecated, use [tool:pytest] instead.

Is there any reason not to do this section re-name?
E.g. will something break because e.g. astropy-helpers relies on this section name?
If not, I'd suggest we try to do this change in setup.cfg section name, no?

@bsipocz

This comment has been minimized.

Show comment
Hide comment
@bsipocz

bsipocz Jun 3, 2017

Member

@cdeil - I shouldn't break anything, and can be changed if you're happy to require pytest 3+ (as it won't work with older versions).

Member

bsipocz commented Jun 3, 2017

@cdeil - I shouldn't break anything, and can be changed if you're happy to require pytest 3+ (as it won't work with older versions).

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Jun 3, 2017

Member

and can be changed if you're happy to require pytest 3+

I think requiring pytest 3.0+ would be OK. But maybe let's merge this change now and first see if that already causes issues for some Gammapy devs, go step by step.

Merging this now. Thanks!

Member

cdeil commented Jun 3, 2017

and can be changed if you're happy to require pytest 3+

I think requiring pytest 3.0+ would be OK. But maybe let's merge this change now and first see if that already causes issues for some Gammapy devs, go step by step.

Merging this now. Thanks!

@cdeil cdeil merged commit b01a7ac into gammapy:master Jun 3, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment