Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spectrum fit for case of no EDISP #1073

Merged
merged 2 commits into from Jun 28, 2017
Merged

Fix spectrum fit for case of no EDISP #1073

merged 2 commits into from Jun 28, 2017

Conversation

@joleroi
Copy link
Contributor

@joleroi joleroi commented Jun 28, 2017

@cdeil This fixes your issue

@joleroi joleroi added the bug label Jun 28, 2017
@joleroi joleroi added this to the 0.7 milestone Jun 28, 2017
@joleroi joleroi self-assigned this Jun 28, 2017
Copy link
Member

@cdeil cdeil left a comment

@joleroi - Thanks!

Looks like you have to change the ref value or lower the tolerance here: https://travis-ci.org/gammapy/gammapy/jobs/247892320#L910

@joleroi
Copy link
Contributor Author

@joleroi joleroi commented Jun 28, 2017

@cdeil Thanks, I can't reproduce the error locally, can such a large deviation just be due to a different architecture?

@cdeil
Copy link
Member

@cdeil cdeil commented Jun 28, 2017

You have index=2.296, on travis-ci index=2.302, the difference is 0.006. I would say this is a small, not a large numerical difference, it's easily possibly that the optimiser stops a little differently on different machines / compilers.

So my suggestion would be to put atol=0.02 here (to have some margin for extra error on other machines / compilers).

@joleroi joleroi force-pushed the joleroi:fix_no_edisp branch from af27745 to 02367e4 Jun 28, 2017
@cdeil cdeil changed the title Fix fits without EDISP and add regression test Fix spectrum fit for case of no EDISP Jun 28, 2017
@cdeil
Copy link
Member

@cdeil cdeil commented Jun 28, 2017

Remaining travis-ci fails for Astropy dev version are from gammapy.astro, completely unrelated.
Merging this now.

@joleroi - Thanks!

@cdeil cdeil merged commit 4698850 into gammapy:master Jun 28, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@cdeil
Copy link
Member

@cdeil cdeil commented Jun 28, 2017

Unrelated fails in master should be fixed by cc5b77b now.

@joleroi joleroi deleted the joleroi:fix_no_edisp branch Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants