Add observation sanity check method to DataStore #1082
@lmohrmann - Thanks!
Ideally, I think it would be much better if we always implement checks by putting results in dicts like in
Another suggestion I have is that it would be nice if you add a test that exercises the new code at least once to make sure it's working (and keeps working as we refactor Gammapy). There's this CTA example
@lmohrmann - Let me know if you want to implement either of these suggestions here, or just merge as-is and leave those suggestions to the future.
@lmohrmann - I see at https://github.com/gammapy/gammapy/pull/1082/commits that you merged master into this feature branch: b6495e4
This is not a problem in this case, we'll leave as-is.
But generally merge commits into feature branches means that overall the git commit history of the project is complex, and makes it harder to review / understand of when which changes happened. So for the future, please