New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON-serialisable source catalog object dict #1083

Merged
merged 2 commits into from Jul 5, 2017

Conversation

Projects
None yet
2 participants
@vorugantia
Contributor

vorugantia commented Jul 5, 2017

@cdeil - This is the PR for the _data_python_dict and _data_python_list source/catalog object properties that we worked on. I've implemented tests in the latest PR for 3FGL and 3FHL source catalog objects. Let me know if anything else is needed.

(I'm now transitioning to work on gamma-sky.net.)

@cdeil cdeil self-assigned this Jul 5, 2017

@cdeil cdeil added the feature label Jul 5, 2017

@cdeil cdeil added this to the 0.7 milestone Jul 5, 2017

@cdeil

cdeil approved these changes Jul 5, 2017

Looks good to me. Let's wait for travis-ci to finish before merging.

@cdeil cdeil merged commit 5292fa3 into gammapy:master Jul 5, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vorugantia vorugantia deleted the vorugantia:cat-json branch Jul 5, 2017

@cdeil cdeil changed the title from Source catalog object converter to JSON-serializable dict to Add JSON-serialisable source catalog object dict Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment