New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flux points upper limit estimation #1084

Merged
merged 4 commits into from Jul 7, 2017

Conversation

Projects
None yet
2 participants
@adonath
Member

adonath commented Jul 7, 2017

This PR implements upper limit estimation for the FluxPointEstimator class. The code quality is not very high (missing doctsrings, unit tests etc.) but this is the case for the whole FluxPointEstimator class. I added the values for dnde_ul, dnde_errn and dnde_errp to the high level test.

@adonath adonath added the feature label Jul 7, 2017

@adonath adonath self-assigned this Jul 7, 2017

@cdeil cdeil added this to the 0.7 milestone Jul 7, 2017

@cdeil

This comment has been minimized.

Member

cdeil commented Jul 7, 2017

OK to merge as-is if you like. I would prefer it you take an extra hour and add docstrings to the two methods explaining what they do (just two lines) and parameters and especially what exactly they return. That'll make it much easier for me or others in the future to understand, debug or extend them.

Specifically: eventually we need to have documentation how the sigma_ul relates to confidence levels, as many people want to compute e.g. "95% CL upper limits" and there's always the issue of one-sided vs two-sided to get right when converting between those p-values and sigmas.
Probably it's not clear what exactly happens at the moment, but @adonath - if you put your best guess on what's computed here in the docstring, then I'll meditate on it over the weekend.

adonath added some commits Jul 7, 2017

@adonath adonath merged commit 1ff7a6c into gammapy:master Jul 7, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@cdeil cdeil changed the title from Implement flux points upper limit estimation to Add flux points upper limit estimation Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment