Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fermi-LAT catalog flux points property #1089

Merged
merged 4 commits into from Jul 25, 2017

Conversation

@adonath
Copy link
Member

@adonath adonath commented Jul 25, 2017

This PR fixes the column names in the .flux_points property for Fermi-LAT sources. Additionally it fixes a bug in Flux_points.to_sed_type(), that was related to spectral model, that use numerical integration to compute integral fluxes. I also added a regression test.

@adonath adonath self-assigned this Jul 25, 2017
@adonath adonath added the bug label Jul 25, 2017
@adonath adonath added this to the 0.7 milestone Jul 25, 2017
@adonath adonath merged commit e26300c into gammapy:master Jul 25, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cdeil cdeil changed the title Fix Fermi-LAT catalog flux points column names Fix Fermi-LAT catalog flux points property Aug 31, 2017
@adonath adonath deleted the adonath:fix_fermi_catalog_fp_column_names branch Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant