Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add default parameters for spectral models #1090
This PR addresses #992 and introduces default values for the spectral model parameters.
A little bit tricky was the choice for parameter min / max default values. I've tried make the choice as general as possible and removed some of the previous default settings (OK with you @joleroi?).
The PR also adds example plots for the spectral models.
I had a quick look at the diff. Don't have much time this week to look in detail. Would suggest you just go ahead and merge.
The only comment I have is whether it makes sense to add a plot example for each class to the API docs, because our docs build is already so slow, and I don't think it's very useful to have those plots, is it?
A different option that I think would be simpler to maintain and useful for users would be to show off examples of models and plotting here:
A method that returns a Jupyter widget where people can play with parameter values and see how the spectrum changes would be best and probably even possible to implement as a generic method in the base class with 10 lines of code, no?
If you think it's a good idea, you could do it here or make a reminder issue.
For my last suggestion, we would also need a list of available spectral models, which definitely should be implemented as a registry. That would also make usage much simpler where people don't have to import each spectral model, but can use that registry and a factory method