New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit warning when HDU loading from index is ambiguous #1105

Merged
merged 1 commit into from Aug 25, 2017

Conversation

Projects
None yet
2 participants
@lmohrmann
Contributor

lmohrmann commented Aug 21, 2017

When multiple entries for the same IRF are encountered in the HDU_INDEX, emit a warning (and return the first one).

@cdeil cdeil self-assigned this Aug 25, 2017

@cdeil cdeil added the feature label Aug 25, 2017

@cdeil cdeil added this to the 0.7 milestone Aug 25, 2017

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Aug 25, 2017

Member

I'm not 100% sure if this will be useful or annoying in practice. But my guess is that it'll be helpful, so merging now. There's also the question when we should log.warn or warnings.warn, again something we might want to revisit for this warning.

Member

cdeil commented Aug 25, 2017

I'm not 100% sure if this will be useful or annoying in practice. But my guess is that it'll be helpful, so merging now. There's also the question when we should log.warn or warnings.warn, again something we might want to revisit for this warning.

@cdeil cdeil merged commit df9e330 into gammapy:master Aug 25, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details

@cdeil cdeil changed the title from Emit a warning when there are multiple types of IRFs present to Emit warning when HDU loading from index is ambiguous Aug 25, 2017

@lmohrmann lmohrmann deleted the lmohrmann:multiple-irf-warning branch Sep 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment