This PR rewrites the GaussianBand2D model and adds it as property to the SourceCatalogHGPS class.
It also adds a high level test, that recomputes the flux values from the large scale emission model in the RSpec region of some HGPS sources. The value agrees within 1% with the one listed in the catalog.
It's mostly a question of the API...in this case I found it difficult, because this class is very much in between other model and data class we have. I decided to push this class more into the direction of a data class (I actually thought about renaming it to LargeScaleComponentHGPS...) and have a convenience layer that we also implemented for the FluxPoints, EventList or SourceCatalog class: the actual data is stored in a .table attribute and then we provide easy access to the most important quantities including unit handling etc.
My suggestion was just because the 8 one-line methods don't add extra functionality and I slightly prefer the smaller API. But it's not really a big gain because then you have to list the available parameters in a single docstring. You choose and merge as you like.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.