Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CTA sensitivity estimator #1136

Merged
merged 4 commits into from Sep 18, 2017
Merged

Conversation

@adonath
Copy link
Member

@adonath adonath commented Sep 15, 2017

This is a follow-up PR to #1123. It includes the changes introduced in #1123, rebased on the current master. It was not possible to rebase without conflicts in test_cta_sensitivity.py. So I kept all the changes in the file and marked all tests as xfail.

I would suggest, that we merge this PR as is and @bkhelifi can start a new branch from master to fix the tests.

@cdeil cdeil self-assigned this Sep 18, 2017
@cdeil cdeil added the feature label Sep 18, 2017
@cdeil cdeil added this to the 0.7 milestone Sep 18, 2017
@cdeil
cdeil approved these changes Sep 18, 2017
@cdeil cdeil merged commit 32ff923 into gammapy:master Sep 18, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@cdeil cdeil changed the title Improve CTA sensitivity estimator: follow up to #1123 Improve CTA sensitivity estimator Feb 28, 2018
@adonath adonath deleted the adonath:cta_sensitivity_bkhelfi branch Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants