Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix PSF evaluate error at low energy and high offset #1150
@bkhelifi - I would suggest to extend the test in two ways:
- add an assert for the current "failure case" that establishes the the current return value (presumably the 1D
TablePSFcomputed has value 0 for all entries?
- add a second test case at a different offset / energy where a PSF exists (e.g. offset 1 deg, energy 1 TeV), and assert that the resulting PSF is reasonable (e.g. R68 ~ 0.04 deg) via an
assert_allclose. We currently don't have any tests for CTA 1DC data, so it would be good to establish via this test that it's working.
@bkhelifi - I'd be happy to add those lines and merge, but after the HGPS call. It's at 10 am and I'll come over at ~ 11 am after. There is fresh coffee in your room.