Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ring background estimation #1166

Merged
merged 3 commits into from Oct 17, 2017

Conversation

@adonath
Copy link
Member

@adonath adonath commented Oct 16, 2017

This PR partly fixes the ring background estimation, when used with the IACTBasicImageEstimator, by assuming constant on_exposure instead of the gamma exposure. This still isn't correct, but gets rid of the prominent artefacts at high offsets. It also fixes the AdaptiveRingBackgroundEstimator to only fill all maps within the FoV.

@adonath adonath mentioned this pull request Oct 16, 2017
@cdeil cdeil added the bug label Oct 16, 2017
@cdeil cdeil added this to the 0.7 milestone Oct 16, 2017
@cdeil
cdeil approved these changes Oct 17, 2017
Copy link
Member

@cdeil cdeil left a comment

@adonath - For me it's OK to put this in now, and then do testing in master in the coming weeks. Or do you want me to review the implementation / tests here now?

@adonath adonath merged commit 6059b71 into gammapy:master Oct 17, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@adonath adonath deleted the adonath:fix_ring_background_estimation branch Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants