Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage reports to continuous integration on coveralls #12

Merged
merged 1 commit into from Mar 3, 2014

Conversation

@cdeil
Copy link
Member

@cdeil cdeil commented Mar 2, 2014

Set up automatic coverage reports via https://coveralls.io/ for gammapy

@ghost ghost assigned cdeil Aug 22, 2013
@cdeil
Copy link
Member Author

@cdeil cdeil commented Mar 1, 2014

Coveralls is now active (commenting on pull requests) for gammapy:
Example: https://coveralls.io/builds/558373

But the coverage report is empty ... probably needs astropy/astropy#2132 to be merged first.

@cdeil
Copy link
Member Author

@cdeil cdeil commented Mar 2, 2014

@astrofrog @mdboom With the instructions from astropy/package-template#39 coverage for the gammapy affiliated package now works.

However, for some reason, coverall tries to submit coverage reports for astropy instead of gammapy:
https://coveralls.io/builds/562456 (empty coverage report)
https://travis-ci.org/gammapy/gammapy/jobs/19935021#L843

$ if [[ $SETUP_CMD == 'test --coverage' ]]; then coveralls; fi
Submitting coverage to coveralls.io...
No source for /home/travis/home/travis/virtualenv/python2.7/lib/python2.7/site-packages/astropy/__init__
No source for /home/travis/home/travis/virtualenv/python2.7/lib/python2.7/site-packages/astropy/config/__init__

Any idea why this is happening?

@mdboom
Copy link
Contributor

@mdboom mdboom commented Mar 3, 2014

It looks like gammapy's .travis.yml is installing astropy from the wheels.astropy.org wheelhouse which gives you astropy 0.3.1, which doesn't have astropy/astropy#2132 merged. That means it's using astropy's coveragerc, which tells it to collect coverage results for astropy, not gammapy. astropy/astropy#2132 is milestoned for 0.3.2, so it should make it out to the wheels pretty soon.

@cdeil
Copy link
Member Author

@cdeil cdeil commented Mar 3, 2014

@mdboom Thanks for explaining what's going on.
Merging this now so that we can use it locally.

cdeil added a commit that referenced this pull request Mar 3, 2014
@cdeil cdeil merged commit a7524fc into gammapy:master Mar 3, 2014
1 check was pending
1 check was pending
@cdeil
default The Travis CI build is in progress
Details
@cdeil cdeil deleted the cdeil:issue_12 branch May 30, 2014
@cdeil cdeil changed the title Add coveralls Add coverage reports to continuous integration on coveralls Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants