Add theta2 distribution plot to EventList class #1207
cdeil left a comment
@vuillaut - Thanks for the pull request! I left some inline comments.
Maybe the biggest question here is whether to allow the caller to choose different reference positions for the offset computation. There's two possible positions in the event file header that you could access, namely pointing and "object" position. The "object", i.e. target of observation is sometimes listed in the header and sometimes not.
One option is no
i.e. use the pointing position by default, but give the caller the option to choose something else.
Anything here is fine with me, please choose what you find best, and make the docstring and implementation consistent.
Usually I add commits to pull requests and merge via the Github web interface. But @vuillaut - it looks like you disallowed "edits from maintainers", which makes it harder to collaborate and integrate your pull requests. Would you mind to change to "allow edits from maintainers"?