New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gammapy-data-show and gammapy-cube-bin #1227

Merged
merged 2 commits into from Dec 2, 2017

Conversation

Projects
None yet
1 participant
@cdeil
Member

cdeil commented Dec 2, 2017

This PR removes two old command line scripts: gammapy-data-show and gammapy-cube-bin.

  • gammapy-data-show wan't useful for most users, and if we want it, it should be completely rewritten, using a registry of known file formats to Gammapy, figuring out what the files contain and printing or plotting info.
  • gammapy-cube-bin was without tests and broken for a long time without anyone noticing, i.e. no-one was using it. (the SkyCube.fill method was renamed SkyCube.fill_events, but gammapy-cube-bin wasn't updated). Again, if we want such cli tools, they need to be re-written and added back with good docs and tests.

IMO keeping the old versions doesn't help at all, if anything it's an impediment to someone building a new high-level ftools or config based interface on Gammapy. So I'll remove some more old stuff soon ...

@cdeil cdeil added the cleanup label Dec 2, 2017

@cdeil cdeil added this to the 0.7 milestone Dec 2, 2017

@cdeil cdeil self-assigned this Dec 2, 2017

@cdeil cdeil merged commit 48d7ae1 into gammapy:master Dec 2, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment