New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HESS HGPS catalog source class #1231

Merged
merged 3 commits into from Mar 26, 2018

Conversation

Projects
None yet
1 participant
@cdeil
Member

cdeil commented Mar 23, 2018

I just now did some small updates to the HESS HGPS catalog code in a69d05b and e6e3a39 .

This is a reminder issue for further improvements that should be done at some point:

  • In SourceCatalogHGPS._make_source_object the hasattr lines for components and associations can be removed, those should always be available. I think the hasattr in SourceCatalogObjectHGPS._info_components can also be removed, if we simply put empty lists if there are no components.
  • There's also a TODO concerning _attach_identification_info that should be implemented or removed.
  • Source object should contain info on components and associations
  • There should be a unit test for HGPSGaussComponent (name and index properties are currently not covered, str is executed, but no assert on content)
  • The 2-Gauss case in spatial model is not covered
  • The spatial model tests only assert on amplitude, not other properties
  • give access to powerlaw spectrum for all sources

@cdeil cdeil added the cleanup label Dec 6, 2017

@cdeil cdeil added this to the 0.8 milestone Dec 6, 2017

@cdeil cdeil self-assigned this Mar 23, 2018

@cdeil cdeil added the feature label Mar 26, 2018

@cdeil cdeil merged commit 4cb8fb2 into gammapy:master Mar 26, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@cdeil cdeil referenced this pull request Mar 26, 2018

Open

Improve HGPS catalog spatial model #1351

0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment