Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIG 3 - Plan for dropping Python 2.7 support #1278

Merged
merged 3 commits into from Nov 30, 2018
Merged

PIG 3 - Plan for dropping Python 2.7 support #1278

merged 3 commits into from Nov 30, 2018

Conversation

@cdeil
Copy link
Member

@cdeil cdeil commented Feb 1, 2018

This PIG is a proposal that we should drop Python 2.7 support with Gammapy and users and developers are encouraged to update to Python 3 now. No timescale is proposed yet, this is just to mention the goal and have a place for discussion on this question.

  • Let us know if you need help to update to Python 3!
  • Let us know if you can't update for some reason, and need continued Python 2.7 support from future Gammapy releases.

cc @woodmd and @eacharles from Fermipy.

@cdeil cdeil added the pig label Feb 1, 2018
@cdeil cdeil added this to the wishlist milestone Feb 1, 2018
@cdeil cdeil requested a review from woodmd Feb 1, 2018
@woodmd
Copy link
Member

@woodmd woodmd commented Feb 1, 2018

The Fermi STs only support python 2 so for the moment Fermipy can't update to Python 3 (although some modules that don't import the STs have already been updated). To the extent that we would like to continue moving functionality from Fermipy into gammapy we would prefer if gammapy could keep python 2 support until we can update Fermipy to Python 3.

I've recently had some discussions within the Fermi team and there seems to be support for migrating the Fermi STs to python 3. However the timeline is still pretty uncertain and I doubt a python 3 compatible ST release would be ready sooner than a ~year from now. We're having our software meeting the week after next so we will have some more information about timelines at that point.

@cdeil
Copy link
Member Author

@cdeil cdeil commented Sep 8, 2018

@woodmd or @dimauromattia or @eacharles - is there a plan / timeline for Python 3 support in the Fermi ST and Fermipy?

A recent CTA Gammapy user survey (50 responses) showed that 40% still use Python 2.7, which I found surprising. I thought the fraction of Python 2 users very small already.

So overall it looks like we'll keep supporting Python 2.7 for a while. But given that many packages (e.g. Jupyter / ipython / Astropy) have dropped Python 2.7 support and a more (e.g. Numpy and core Python itself) will drop it in 2019. It would be nice if we in Gammapy could as well at some point.

There's also https://github.com/astropy/astropy-healpix and https://github.com/astropy/regions which very likely will mature and land as astropy.healpix and astropy.regions in Astropy core, and since Astropy is Python 3 only already, there's a pretty good motivation to drop Python 2 support in those packages now (which simplifies the C interfaces e.g.), exept for that fact that we still need to support Python 2 in Gammapy and are using regions already and want to use astropy-healpix very soon.

screen shot 2018-09-09 at 00 20 06

@cdeil
Copy link
Member Author

@cdeil cdeil commented Nov 22, 2018

@woodmd @dimauromattia @eacharles @adonath @registerrier - I have updated the PIG (basically re-written). Please have a look and comment here.

The proposal is to have Gammapy v0.10 in January 2019 as the last Gammapy version to support Python 2.7. And to support Fermipy, we will backport bug-fixes to v0.10.x and make bugfix releases there on request / as needed.

This allows Gammapy to move ahead in 2019 to work towards Gammapy 1.0 and an application as CTA science tools (see #1841), and I hope is an OK solution for Fermipy?

@cdeil cdeil requested review from adonath and registerrier and removed request for woodmd Nov 29, 2018
@cdeil cdeil assigned cdeil and unassigned woodmd Nov 29, 2018
Copy link
Member

@adonath adonath left a comment

I've marked one typo. No further comments from my side. Thanks @cdeil!

All earlier Gammapy versions, up to Gammapy v0.10, support Python 2.7 and of
course will remain available indefinitely.

Use surveys in 2018 have shown that most Gammapy users are already on Python 3.

This comment has been minimized.

@adonath

adonath Nov 30, 2018
Member

Typo -> "User surveys..."

@cdeil cdeil dismissed stale reviews from registerrier and adonath via 4060aa3 Nov 30, 2018
@cdeil
Copy link
Member Author

@cdeil cdeil commented Nov 30, 2018

I didn't receive any further comments on this in the past week. Merging this now.
Thank you to all that provided feedback on this.

Like I already said: if anyone needs help with Python 2 vs 3 or in general Python issues and questions, I or the others from the Gammapy team are happy to help any time!

@cdeil cdeil merged commit 0598875 into gammapy:master Nov 30, 2018
5 checks passed
5 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 125 Issues, 0 Patches – Tests: passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20181130.4 succeeded
Details
@cdeil cdeil mentioned this pull request Nov 30, 2018
@cdeil cdeil modified the milestones: wishlist, 0.10 May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants