Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add flux point computation using Lafferty & Wyatt (1995) #128
Here's the API we discussed just now:
The documentation of the format should be in
Implements as we discussed yesterday - seems to give consistent conversion between integral and differential fluxes and back again. Still need to check whether the actual values are correct though.
I still need to:
Just wondered if the implementation seems roughly OK to you/if there is anything missing or that should obviously be changed?
The unit test test_compute_differential_flux_points() currently fails due to insufficient info about published data points it compares to i.e powerlaw index/spectral model/how energies are calculated in bins (although the values aren't wildly off). I guess comparison against a better understood dataset is the way forward here? Any suggestions of any?
Otherwise, can you please review?
Here's the analytical check where the point should go for power-laws we just coded together:
added a commit
this pull request
Jul 10, 2014
Jul 10, 2014
1 check failed
referenced this pull request
Jul 11, 2014
@ellisowen This is online now ... very nice ... thanks! https://gammapy.readthedocs.org/en/latest/tutorials/flux_point.html