Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add methods for WCS maps #1281
This PR implements some methods for
These methods operate only in the spatial dimension of the map. We could consider extending the methods to operate on non-spatial dimensions but this is probably a less common use case. Some parts of the current implementation are still missing -- namely support for all padding modes.
This PR also includes a new
I've now added
After experimenting with these there are some aspects of their behavior that's not completely ideal -- adding/removing a ring of pixels has the effect of distorting the shape of the geometry in unpredictable ways depending on where you are on the sky. If the pixel size is sufficiently small the distortion effect is pretty small but it's something to keep in mind. In light of this I was thinking that we might also want to an option to allow padding/cropping as a function of angle instead of pixel width. Thus the method signatures could look something like: