New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exposure and flux units in IACTBasicImageEstimator #1305

Merged
merged 2 commits into from Feb 14, 2018

Conversation

Projects
None yet
2 participants
@gallanty
Contributor

gallanty commented Feb 14, 2018

The 'exposure' and 'flux' SkyImages returned by IACTBasicImageEstimator
had empty units. Added units in correct SkyImage format to exposure
and flux, and fix so that units are carried over after SkyImage.paste()
[which currently doesn't handle the units].

@cdeil cdeil self-assigned this Feb 14, 2018

@cdeil cdeil added the bug label Feb 14, 2018

@cdeil cdeil added this to the 0.7 milestone Feb 14, 2018

@cdeil

This comment has been minimized.

Member

cdeil commented Feb 14, 2018

@gallanty - Thanks!

I ran this locally and tests are still passing:

$ python -m pytest -v gammapy/image/tests/test_basic.py 

Merging now.

In principle a regression test should be added in gammapy/image/tests/test_basic.py (i.e. a test and assert that fails before the fix and passes after), but since IACTImageEstimator and SkyImage will be completely replaced by new code soon, it doesn't make much sense to spend time to add tests there.

@cdeil

cdeil approved these changes Feb 14, 2018

@cdeil cdeil merged commit 492d5bb into gammapy:master Feb 14, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment