Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove u.ct from gammapy.spectrum #1341

Merged
merged 1 commit into from Mar 20, 2018
Merged

Conversation

@joleroi
Copy link
Contributor

@joleroi joleroi commented Mar 16, 2018

See discussion in #1337

@joleroi joleroi added this to the 0.8 milestone Mar 16, 2018
@joleroi joleroi self-assigned this Mar 16, 2018
@cdeil
cdeil approved these changes Mar 16, 2018
Copy link
Member

@cdeil cdeil left a comment

LGTM. Thanks!

The one fail in TestIACTBasicImageEstimator.test_run is unrelated, already present in Gammapy master:
https://travis-ci.org/gammapy/gammapy/jobs/354312810#L1897

@registerrier - I think you introduced this in #1331 (see https://travis-ci.org/gammapy/gammapy/builds). Can you please fix?
(either add a commit here, or merge this PR, and then fix it in a follow-up PR or via a commit in master).

If it's not clear what the problem is, let me know and I can investigate.

@cdeil cdeil assigned registerrier and unassigned joleroi Mar 16, 2018
@registerrier registerrier merged commit 3b14830 into gammapy:master Mar 20, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@registerrier
Copy link
Contributor

@registerrier registerrier commented Mar 20, 2018

I can not reproduce the test issue on my version with python3.6. I need to test with python 2.7.

@joleroi joleroi deleted the joleroi:remove_ct branch Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants