New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first draft of LightCurve model class #1367

Merged
merged 1 commit into from Apr 11, 2018

Conversation

Projects
None yet
1 participant
@cdeil
Member

cdeil commented Apr 10, 2018

This PR adds a first draft of a LightCurve model class.

The scope / timescale here is very limited. It's just to add something to help compute mean per-run fluxes for the LC for this CTA DC-1 check, which is needed ASAP:
https://github.com/gammasky/cta-analyses/tree/master/dc-1-checks/agn_j1224

I've left "TODO" comments in the docstrings about things we need to discuss / improve.

@bkhelifi @cboisson @jlenain @labsaha - If one of you has suggestions on this today, let me know and I'll implement them tonight. Otherwise I'll just merge this in as a very preliminary first version, and we can discuss and improve it in the coming weeks.

@cdeil cdeil added the feature label Apr 10, 2018

@cdeil cdeil added this to the 0.8 milestone Apr 10, 2018

@cdeil cdeil self-assigned this Apr 10, 2018

@cdeil

This comment has been minimized.

Member

cdeil commented Apr 10, 2018

I've added an example how to use this class for the 1DC check here:
https://github.com/gammasky/cta-analyses/blob/master/dc-1-checks/agn_j1224/model_fluxes.py
I just wrote the script, didn't check the values yet.

@bkhelifi @cboisson - Can you please compare to the fluxes you find in the Gammapy analysis there, and adjust the energy band for the model flux computation to whatever you use in the Gammapy analysis?

@cdeil

This comment has been minimized.

Member

cdeil commented Apr 11, 2018

Merging this now so that we can start using it for the DC1 LC check.

@cdeil cdeil merged commit a64e00c into gammapy:master Apr 11, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment