New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D analysis functions using gammapy.maps #1372

Merged
merged 3 commits into from Apr 12, 2018

Conversation

2 participants
@registerrier
Contributor

registerrier commented Apr 12, 2018

This PR introduces the functions discussed in the PIG-002.
They allow to build simple 3D reduced datasets and irfs using ~gammapy.maps.

@cdeil cdeil self-assigned this Apr 12, 2018

@cdeil cdeil added feature pig and removed pig labels Apr 12, 2018

@cdeil cdeil added this to the 0.8 milestone Apr 12, 2018

@cdeil

This comment has been minimized.

Member

cdeil commented Apr 12, 2018

I'm merging this now.

Just in case anyone is following these developments (e.g. @joleroi ). The plan is that I continue working on gammapy.cube and examples/3D this afternoon, and we try to get a working 3D analysis (both prepare and fitting steps) example using gammapy.maps ASAP.

@joleroi - If you can merge in your #1335 soon, we could try to use it together tomorrow to make a 3D Cash stats fit.

@cdeil cdeil merged commit b9555e0 into gammapy:master Apr 12, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@cdeil

This comment has been minimized.

Member

cdeil commented Apr 12, 2018

@registerrier - Thanks!

@cdeil cdeil changed the title from Adding 3D methods from PIG 2 to Add new 3D analysis code from PIG 2 Apr 12, 2018

@cdeil cdeil referenced this pull request Apr 12, 2018

Merged

Improve 3D analysis code using gammapy.maps #1373

5 of 5 tasks complete

@cdeil cdeil changed the title from Add new 3D analysis code from PIG 2 to Add 3D functions using gammapy.maps Apr 12, 2018

@cdeil cdeil changed the title from Add 3D functions using gammapy.maps to Add 3D analysis functions using gammapy.maps Apr 12, 2018

@registerrier registerrier added this to Done in Map analysis Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment