New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 3D model evaluation from SkyCube to Map #1378

Merged
merged 1 commit into from Apr 16, 2018

Conversation

Projects
None yet
1 participant
@cdeil
Member

cdeil commented Apr 16, 2018

This PR changes the 3D model evaluation from SkyCube to Map.

@joleroi @registerrier - I'm just starting to work on this now, but I wanted to open the PR early to avoid conflicts of us editing the same code. I will try to keep my edits limited to the five files that I started to edit here. That should avoid overlap e.g. with #1377 or @registerrier with any edits e.g. in new.py or test_new.py if you have time to work on those.

@cdeil cdeil added this to the 0.8 milestone Apr 16, 2018

@cdeil cdeil self-assigned this Apr 16, 2018

@cdeil

This comment has been minimized.

Member

cdeil commented Apr 16, 2018

I've refactored the code we already had to a SkyModel and SkyModelMapEvaluator and added a few tests. The example_3d_simulate.py is now cleaned up and runs.

I'd like to merge this in and then we try to get example_3d_fit.py to run and give a correct spectral fit result for a simple case (first without PSF / background / EDISP, then add those features).

@cdeil cdeil merged commit 9030656 into gammapy:master Apr 16, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment