Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Update catalog to new model classes #1387
This PR updates the catalog code to use the new spatial model classes.
This is work in progress, it's currently failing.
I noticed that two things are missing before this can be finalised:
The following changes should be done here also:
@joleroi - Yes, I would suggest to implement a plus operator for now for spatial and sky models also, like you did for spectral models. Is code re-use advisable e.g. via a mixin class or would you copy & paste?
This is not super efficient, e.g. if there was a special
referenced this pull request
Apr 25, 2018
I've finished the change of gammapy.catalog to use the new model classes here. This is ready to merge if CI passes. There's plenty of remaining open TODO that I left as inline comments, but this is as far as I want to go in this PR. We can then continue with this in new PRs next week.
@joleroi - added a little class SkySumModel to hold the multi-Gauss HGPS sources. I just put it in
@adonath - I xfailed the image catalog estimator tests for now. The tests should be rewritten to use SkyMapEvaluator, and then the old ImageEstimator can be removed.
The API to fill parameter errors is cumbersome, and in many cases only model values are filled, parameter errors and tests / asserts on those values still need to be added. To be done after #1398 .