Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old spatial models and CatalogImageEstimator #1401

Merged
merged 6 commits into from Apr 27, 2018

Conversation

@cdeil
Copy link
Member

@cdeil cdeil commented Apr 26, 2018

This PR removes the old code that has been rewritten:

Remove spatial models in gammapy/image/models/shapes.py, rewritten in gammapy/image/models/new.py

Remove old CatalogImageEstimator in gammapy/image/catalog.py.

We never advertised these things, I think only one or two people used the old code. For morphology fitting so far we advertised Sherpa, which is independent. Keeping old and new in parallel would be super confusing to users. That's why this goes out without deprecation period.

Reminders to add a few things that we remove here to the new classes are in #1399 and #1400.

@cdeil cdeil added the cleanup label Apr 26, 2018
@cdeil cdeil added this to the 0.8 milestone Apr 26, 2018
@cdeil cdeil self-assigned this Apr 26, 2018
@cdeil cdeil force-pushed the cdeil:rm-old-spatial-models branch from f07fc78 to 3e2a108 Apr 26, 2018
@cdeil cdeil merged commit bd020db into gammapy:master Apr 27, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joleroi
Copy link
Contributor

@joleroi joleroi commented Apr 27, 2018

+9 -1,334 - Today was a good day 👷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants