Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove old spatial models and CatalogImageEstimator #1401
Conversation
cdeil
added some commits
Apr 26, 2018
cdeil
added
the
cleanup
label
Apr 26, 2018
cdeil
added this to the 0.8 milestone
Apr 26, 2018
cdeil
self-assigned this
Apr 26, 2018
cdeil
added some commits
Apr 26, 2018
cdeil
merged commit bd020db
into
gammapy:master
Apr 27, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cdeil commentedApr 26, 2018
This PR removes the old code that has been rewritten:
Remove spatial models in
gammapy/image/models/shapes.py, rewritten ingammapy/image/models/new.pyRemove old
CatalogImageEstimatoringammapy/image/catalog.py.We never advertised these things, I think only one or two people used the old code. For morphology fitting so far we advertised Sherpa, which is independent. Keeping old and new in parallel would be super confusing to users. That's why this goes out without deprecation period.
Reminders to add a few things that we remove here to the new classes are in #1399 and #1400.