Remove old spatial models and CatalogImageEstimator #1401
Merged
Conversation
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR removes the old code that has been rewritten:
Remove spatial models in
gammapy/image/models/shapes.py, rewritten ingammapy/image/models/new.pyRemove old
CatalogImageEstimatoringammapy/image/catalog.py.We never advertised these things, I think only one or two people used the old code. For morphology fitting so far we advertised Sherpa, which is independent. Keeping old and new in parallel would be super confusing to users. That's why this goes out without deprecation period.
Reminders to add a few things that we remove here to the new classes are in #1399 and #1400.